added feature for extra delay for grpc apis #71
Conversation
|
Can we merge this pr? Ardiannn08 approved it. |
| } | ||
|
|
||
| type Output struct { | ||
| Delay Duration `json:"delay"` |
There was a problem hiding this comment.
I think we can't do it directly under Output struct, can you please create a Meta field and put duration under it?
There was a problem hiding this comment.
Hey @jekiapp Duration is meta field defined in file stub/duration.go, such that
type Duration struct {
time.Duration
}
There was a problem hiding this comment.
@shubhjha123 I mean like this
type Output struct{
Meta Meta
}
type Meta struct{
Delay Duration
}
|
Hi, sorry for the delayed review 🙏 I just saw it today. if you're nakama you can reach me by @jeki in slack. |
|
@jekiapp @shubhjha123 @Ardiannn08 is somebody looking to merge this? This seems to be a need now. |
|
What is the status on this? |
|
Is this feat still planned to be merged? Adding delay is a very useful feature for mocking several real test cases, good to have this. |
6 participants
In our use of gripmock we came across a need of extra delay over grpc response. Added code for extraa delay for grpc apis, which can help library users to configure any delay in their api response.